feat(sdk): Lets SDK use PublicKeys from policy service#1352
Closed
dmihalcik-virtru wants to merge 3 commits intomainfrom
Closed
feat(sdk): Lets SDK use PublicKeys from policy service#1352dmihalcik-virtru wants to merge 3 commits intomainfrom
dmihalcik-virtru wants to merge 3 commits intomainfrom
Conversation
Deferred to not block releases until everything is bumped
Lots of things are declared in the sdk package, so this is easier than factoring shared items into a helper package that would otherwise introduce bidirectional package deps between sdk (root) and autoconfigure (internal) packages
- Lets the SDK load kas keys from the policy service - This was removed/unsupported before, since the SDK requires Key IDs, but the service previously did not store them - Adds a sample round trip that loads a key from a non-existant KAS to validate that the SDK doesn't call out when the key is loaded into the policy service
dmihalcik-virtru
force-pushed
the
feature/plain-text-alg-not-enum
branch
from
8d471a5 to
19ced97
Compare
dmihalcik-virtru
changed the title
This comment has been minimized.
This comment has been minimized.
1 similar comment
Contributor
|
Warning This pull request does not reference any issues. Please add a reference to an issue in the body of the pull request description. |
Member
Author
|
Wrong branch. Use #1346 instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.